Fix Incident - deprecation warning incorrectly displayed #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix the bug - deprecation warning incorrectly displayed
Originally, we have the custom variable substitution, but it will also handle the connection string like this, which we have the regex to detect if it's contains
:variable
, it will detect connection string as variable substitution case.Connection string:
mysql+mysqldb://user:password@127.0.0.1:3306/db
(
:password
was treat as variable)Fix by executing the
_var_expand
after the command is parsed byparse.parse()
, so it would not contain connecting string anymoreIssue ticket number and link
Closes #203
Checklist before requesting a review
📚 Documentation preview 📚: https://jupysql--213.org.readthedocs.build/en/213/